Allow setSettings/setGlobalSettings to accept updater callbacks#135
Open
fhollermayer wants to merge 2 commits intoelgatosf:mainfrom
Open
Allow setSettings/setGlobalSettings to accept updater callbacks#135fhollermayer wants to merge 2 commits intoelgatosf:mainfrom
setSettings/setGlobalSettings to accept updater callbacks#135fhollermayer wants to merge 2 commits intoelgatosf:mainfrom
Conversation
fbe479b to
1226495
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change extends the existing functionality of
Action.setSettingsandsettings.setGlobalSettingsby adding overloads that accept a callback function instead of a static object. The callback receives the current settings and returns the updated settings, allowing updates to be expressed relative to the existing state. As a result, these setter functions can be used without explicitly calling the corresponding retrieval methods.or
This PR is intended as a compilable proposal rather than a change request—feel free to discard it if it’s not a good fit.